Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse stored config details to script-based visualizations #18651

Merged
merged 14 commits into from
Sep 13, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Aug 6, 2024

This PR injects stored visualization details into the data attribute of a target container element. This allows script-based visualizations to access stored details if needed. Script-based visualization can consist of a plain JavaScript file or full application modules. xref: #18637

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Aug 6, 2024
@guerler guerler force-pushed the parse_missing_viz_config branch from d982f8e to 3655a6c Compare August 7, 2024 04:46
@guerler guerler marked this pull request as ready for review August 7, 2024 16:31
@guerler guerler force-pushed the parse_missing_viz_config branch from 3655a6c to e262f38 Compare August 31, 2024 12:22
@guerler guerler force-pushed the parse_missing_viz_config branch from 8d68de7 to 08db1e3 Compare September 4, 2024 06:56
@guerler guerler force-pushed the parse_missing_viz_config branch from 08db1e3 to 1a1e8a9 Compare September 4, 2024 06:58
@guerler guerler force-pushed the parse_missing_viz_config branch from 0c23950 to ff08779 Compare September 4, 2024 11:05
@dannon dannon self-requested a review September 5, 2024 02:04
@guerler guerler force-pushed the parse_missing_viz_config branch from b90d022 to 4e3eebd Compare September 5, 2024 07:06
@guerler guerler added highlight Included in user-facing release notes at the top labels Sep 12, 2024
@dannon dannon merged commit bd54d46 into galaxyproject:dev Sep 13, 2024
52 of 55 checks passed
@guerler guerler deleted the parse_missing_viz_config branch September 13, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX area/visualizations highlight Included in user-facing release notes at the top kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants